wooot 100 on term test two
hopefully my TA reads this before marking my assignment. it seems that looking over my code after looking at the report.txt generated on markus, i came to a conclusion
1. e should have been RegexTreeNode('e', []), rather than RegexTreeNode(' ', []). we're failing most of our tests because its complaining that its not exactly right.
2. our code processes the tree perfectly otherwise, except for one mishap: we didn't process the final outer brackets. so a regex statement like '(1|0).(1|0)' would be processed completely fine, but '((1|0).(1|0))' would not, because the outermost bracket would screw up the code. this is really disappointing because the code works fine otherwise, and its literally one line of code that fixes that problem, but we might lose a lot of marks because "the process doesn't work"
finally, some odds and ends in terms of processing the regex_match. for example, i thought e was a space, not an empty string, and some confusion on what starnode was and what it meant.
hopefully assignment 2 isn't that bad. our code works except for the two huge points mentioned above, which are killer.
No comments:
Post a Comment